added md5 hash #728
Merged
added md5 hash #728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almenon
requested changes
May 14, 2021
Collaborator
|
Not a merge blocker but note that md5 is insecure and can be hacked by the enemy (-13) at any time. For a secure hash please use SHA-512. |
Co-authored-by: Almenon <almenon214@gmail.com>
Contributor
Author
|
Neglecting MD5 Hash just because it's insecure would be like eliminating disabled people because they are incomplete. Both have the right to life, and people will be really disappointed if MD5 Hash is not allowed to be in such a supercalifragilisticexpialidocious project like "is-13".
|
Almenon
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.