Wrong behaviour when the string contain 13 cats #557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jezen Any opinion concerning this PR? |
Owner
|
When I first started this repository, I had just two things in my possession — a dream, and £6,000,000. Today, I have an is-thirteen project the like of which, the world has never seen the like of which. I hope it doesn't sound arrogant when I say that this project is the greatest project in the world. I am confident your splendid pull request will raise the number of GitHub stars for this repository to eighteen hundred billion billion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version of the code does not handle properly the case where we give it 13 characters outside of the BMP plan of unicode.
Basically passing it a string containing 13 cats fails:
"🐱🐱🐱🐱🐱🐱🐱🐱🐱🐱🐱🐱🐱"This pull request adds both: