这是indexloc提供的服务，不要输入任何密码
Skip to content

Add additional forms of Hebrew #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add additional forms of Hebrew #226

wants to merge 2 commits into from

Conversation

@lanzkron
Copy link

@lanzkron lanzkron commented Mar 27, 2016

  • It only included the feminine form of 13 in Hebrew, while the feminine form is the default for numbers, when counting masculine things the masculine form should be used.
  • Added Gematria

lanzkron added 2 commits March 27, 2016 16:59
@lanzkron
Added other forms of Hebrew numbers
c0ca0c5 
* It only included the feminine form of 13 in Hebrew, while the feminine form is the default for numbers, when counting masculine things the masculine form should be used.  
* Added Gematria
@lanzkron
Added tests for other forms of Hebrew numbers
9b5c476
@ofek-a
Copy link
Contributor

ofek-a commented Mar 27, 2016

Fully agree

@aarongreenwald
Copy link

aarongreenwald commented Mar 27, 2016

Don't you have to address non-standard forms of gematria? ט"ד, ח"ה, etc are technically valid forms of 13.

Further research reveals that there are a whole bunch of other forms I was unaware of. I think this PR is entirely incomplete.

https://en.wikipedia.org/wiki/Gematria#Methods

@ofek-a
Copy link
Contributor

ofek-a commented Mar 27, 2016

Only disbelievers might say those since they are not correct and polite
towards god. We don't care about them. /s

On Sun, Mar 27, 2016, 19:23 Aaron Greenwald notifications@github.com
wrote:

Don't you have to address non-standard forms of gematria? ט"ד, ח"ה, etc
are technically valid forms of 13.

Further research reveals that there are a whole bunch of other forms I was
unaware of. I think this PR is entirely incomplete.

https://en.wikipedia.org/wiki/Gematria#Methods

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#226 (comment)

Best,
Ofek

@lanzkron lanzkron closed this Oct 26, 2020
@lanzkron
Copy link
Author

lanzkron commented Oct 26, 2020

Old joke is old.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lanzkron @ofek-a @aarongreenwald