这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@kaBeech
Copy link
Contributor

@kaBeech kaBeech commented Jun 12, 2024

I was just fixing a bunch of similar errors for my font, so I thought I might do yours as well 😸

Fixes self-intersections, bad directions, and points missing at extrema.

There are some self-intersections left, but I did the ones that didn't require manual adjustment.

Thanks for maintaining this awesome font!

kaBeech and others added 5 commits June 11, 2024 17:43
Fixes self-intersections, bad directions, and points missing at extrema.

There are some self-intersections left, but this seems like a good start 😸
@jesusmgg
Copy link
Owner

This got some conflicts after merging #10, can you update the branch?

@jesusmgg jesusmgg assigned jesusmgg and kaBeech and unassigned jesusmgg Jun 21, 2024
@jesusmgg jesusmgg self-requested a review June 21, 2024 02:23
@kaBeech
Copy link
Contributor Author

kaBeech commented Jun 22, 2024

Thank you! Will fix after work tonight!

kaBeech added 3 commits June 23, 2024 01:03
Fixes all remaining self-intersections, missing points at extrema,
and non-integer coordinates, with the exception of the ∄ glyph
@kaBeech
Copy link
Contributor Author

kaBeech commented Jun 23, 2024

Fixed!

I also went ahead and fixed all remaining self-intersections, missing points at extrema,
and non-integer coordinates, with the exception of the ∄ glyph

Thanks again!

@jesusmgg
Copy link
Owner

Thank you very much! This is an amazing addition.

@jesusmgg jesusmgg merged commit 5a13931 into jesusmgg:master Jun 25, 2024
@jesusmgg
Copy link
Owner

jesusmgg commented Jun 25, 2024

I will make a new release probably next week or the next one with all of the accumulated changes.

@kaBeech kaBeech deleted the cleanup-glyphs branch June 25, 2024 18:54
@sunshine-syz
Copy link

Could you also update the nerd font version?

@kaBeech
Copy link
Contributor Author

kaBeech commented Aug 2, 2024

@sunshine-syz IIRC Nerd Fonts will automatically check release versions of their upstream fonts and pull in the updates ahead of their next release. So once Jesús releases a new version we'll have to wait for NF to release their new version

In the meantime you can patch it yourself or try Serious Shanns, my sister fork (which has some glyph changes but misses some characters in Comic Shanns Mono) which I applied the same fixes to =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants