fix TestHttpProbe/returns_the_status_code_if_the_request_is_successful #55
Conversation
|
Thank you! I would prefer to merge a proper solution instead this workaround. The problem here is the function Lines 66 to 67 in 520cd9e Please check this solution. I think it should work: https://stackoverflow.com/a/53332769 |
|
thanks for suggestion it work |
jesusprubio
left a comment
There was a problem hiding this comment.
Thank you. Only a couple of formatting changes are we are ready to merge. :)
pkg/protocols_test.go
Outdated
| server := &http.Server{Addr: hostPort} | ||
| http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { | ||
| mux := http.NewServeMux() | ||
| server := &http.Server{ |
There was a problem hiding this comment.
Please, use one line to define server.
pkg/protocols_test.go
Outdated
| Addr: hostPort, | ||
| Handler:mux, | ||
| } | ||
|
|
There was a problem hiding this comment.
Please, remove the empty lines to keep the formatting consistent.
pkg/protocols_test.go
Outdated
| go func() { | ||
| err := server.ListenAndServe() | ||
| if err != nil && err != http.ErrServerClosed { | ||
| if err := server.Serve(l); err != nil && err != http.ErrServerClosed { |
There was a problem hiding this comment.
Use two different lines. Also to keep the formatting consistent with the codebase.
pkg/protocols_test.go
Outdated
| hostPort := net.JoinHostPort("127.0.0.1", "8080") | ||
| server := &http.Server{Addr: hostPort} | ||
| http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) { | ||
| mux := http.NewServeMux() |
There was a problem hiding this comment.
We don't need a mux for this simple scenario. The line 63 should be enough.
Fixes #52.