这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@ashmaroli
Copy link
Member

@ashmaroli ashmaroli commented Feb 28, 2025

Summary

  • Make the header fixed to the top of viewport to avoid scrolling to top especially when the current page is a very long post.
  • Nav element on small-screens now span the full viewport height regardless of number of link-items.
  • Introduce new include_file / inclusion named nav-items.html to render navigation link-items for all screen-sizes.
  • Move header_pages config data into the minima namespace as minima:nav_pages
  • Menu icon is now a Font Awesome icon instead of inline SVG.

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +major

@jekyllbot jekyllbot merged commit 9258979 into master Mar 3, 2025
3 checks passed
@jekyllbot jekyllbot deleted the improve-nav-xp branch March 3, 2025 14:20
jekyllbot added a commit that referenced this pull request Mar 3, 2025
@Polovinkin
Copy link

Polovinkin commented Mar 5, 2025

sorry, but wanted to ask about this:
"Nav element on small-screens now span the full viewport height regardless of number of link-items."

it looks horrible on mobile screens, what's the point of making that change?

Edit: made the issue about that #860

@Storyyeller
Copy link

Storyyeller commented Mar 23, 2025

Summary

* Make the header fixed to the top of viewport to avoid scrolling to top especially when the current page is a very long post.

I know you mean well, but FWIW, I hate this behavior on websites, and have to spend a lot of time adding an adblocker rule on each site I visit to kill these pointless sticky headers in order to free up screen space so I can read the actual content.

I'm far from the only one either, as you can see from the discussion here for instance.

Making this behavior the default on a widely used website theme seems like it's going to cause a lot of pain for people.

@ashmaroli
Copy link
Member Author

Hello @Storyyeller, thank you for reaching out and voicing your disapproval.
I have one more (major, yet non-breaking) ux change in the works. Once I merge that in, I am going to open a discussion at both talk.jekyllrb.com and the GitHub Discussions for this repository to gauge user opinions about Minima v3 and make changes accordingly.

Storyyeller added a commit to polybdenum/polybdenum.github.io that referenced this pull request Mar 26, 2025
@ashmaroli
Copy link
Member Author

Hello everyone,
I have started a feedback thread at #876 and https://talk.jekyllrb.com/t/minima-v3-preview-feedback/9865.
Feel free to leave comments there as well. I will base decisions based on responses in those threads.

@ashmaroli
Copy link
Member Author

@Storyyeller FYI: I have reverted the sticky-header to previous default state via dfaea3e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants