fix hamburger menu for iOs #85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a dummy onclick handler `onclick = "void(0)"` into the span element of the menu icon will make iOS recognize it as a clickable element. You won't be able to unclick the drop-down menu, however.
Member
|
@melaniewalsh Thank you for digging out a solution. |
CodeFerriCode
added a commit
to FerriNFriends/FerriNFriends.github.io
that referenced
this pull request
Dec 15, 2016
|
What is the status on this? |
|
#111 is a better fix I think. |
Contributor
|
Thanks @melaniewalsh! Going to go with the solution in #111 instead, but appreciate the pull request. Keep 'em coming. |
CodeFerriCode
added a commit
to FerriPlus/FerriPlus.github.io
that referenced
this pull request
Dec 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a dummy onclick handler
onclick = "void(0)"into the span element of the menu icon will make iOS recognize it as a clickable element. You won't be able to unclick the drop-down menu, however.Fix #80