Require at least commonmarker-0.22 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DirtyF
approved these changes
Aug 22, 2021
Member
Author
|
@DirtyF I don't have high-level privileges in this repository. So, could you disable Travis CI as a required check and proceed with the merge? Thanks. |
|
Can a new version be released with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonmarker v0.22 stopped using
ruby-enumand replaced two classes under theCommonMarker::Confignamespace in the commit gjtorikian/commonmarker@ea0f742That broke our plugin.
Therefore, implement a foward-looking change and drop support for older versions of Commonmarker.