[JAX] Make util.lru_cache(..., trace_context_in_key=False) always cache
#30392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f493a4 to
fa4d21e
Compare
util.lru_cache(..., trace_context_in_key=False)util.lru_cache(..., trace_context_in_key=False) always cache
…ache With this change, the implementation of `util.lru_cache(..., trace_context_in_key=False)` is effectively the same as `functools.lru_cache`, except being cleared when JAX backends are cleared. This makes a semantics change when `check_tracer_leaks` is enabled (as in several tests and debugging sessions). Previously, caching was disabled with `check_tracer_leaks` is enabled, which accidentally prevented caching JAX backends and runtime objects after #30324 With this change, these objects will be cached as before, and will avoid performance regression due to such unintended cache misses. PiperOrigin-RevId: 785931431
fa4d21e to
8bfdc0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[JAX] Make
util.lru_cache(..., trace_context_in_key=False)always cacheWith this change, the implementation of
util.lru_cache(..., trace_context_in_key=False)is effectively the same asfunctools.lru_cache,except being cleared when JAX backends are cleared.
This makes a semantics change when
check_tracer_leaksis enabled (as inseveral tests and debugging sessions). Previously, caching was disabled with
check_tracer_leaksis enabled, which accidentally prevented caching JAXbackends and runtime objects after #30324
With this change, these objects will be cached as before, and will avoid
performance regression due to such unintended cache misses.