[pallas:mosaic_gpu] async_load_tmem no longer accepts an idx
#30382
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `idx` is unnecessary, because `ref` can be indexed via `.at[idx]` instead. Note also that `async_store_tmem` does *not* accept `idx`, so this change aligns the two signatures. PiperOrigin-RevId: 785854400
711d466 to
37b6f5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[pallas:mosaic_gpu]
async_load_tmemno longer accepts anidxThe
idxis unnecessary, becauserefcan be indexed via.at[idx]instead.Note also that
async_store_tmemdoes not acceptidx, so this changealigns the two signatures.