before iterating, copy dict that can be popped from via ARC / object deletion #30465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b54bd0 to
ab9f461
Compare
…deletion without this change, we might get unlucky and a pop from `finalize_const` might occur when iterating over `cosntvar_to_val.items()` in `to_jaxpr` PiperOrigin-RevId: 786496020
ab9f461 to
0d3feb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before iterating, copy dict that can be popped from via ARC / object deletion
without this change, we might get unlucky and a pop from
finalize_constmightoccur when iterating over
cosntvar_to_val.items()into_jaxpr