Manually link to composer-bin-plugin installed commands #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise there is no guarantee which version of the library the link was created for, as there might be still multiple versions installed. The plugin will link to the first one that was installed. It might not be the one we expected. i.e. rector installed phpstan in version 0.11.3 as one of its dependencies. phpstan 0.11.4 was also directly requested to be installed in a different composer-bin-plugin namespace. Since rectors phpstan was installed first, the link was pointing to the 0.11.3 version instead of 0.11.4 we expected. As a consequence no phpstan plugins could be loaded.
jakzal
added a commit
to jakzal/phpqa
that referenced
this pull request
Mar 23, 2019
Bug fixes: * Manually link to composer-bin-plugin installed commands to guarantee the correct version of a tool is used jakzal/toolbox#73 Updates: * phan (1.2.6 -> 1.2.7)
jakzal
added a commit
to jakzal/phpqa
that referenced
this pull request
Mar 23, 2019
Bug fixes: * Manually link to composer-bin-plugin installed commands to guarantee the correct version of a tool is used jakzal/toolbox#73 Updates: * phan (1.2.6 -> 1.2.7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise there is no guarantee which version of the library the link was created for, as there might be still multiple versions installed. The composer-bin-plugin will link to the first one that was installed. It might not be the one we expected.
i.e. rector installed phpstan in version 0.11.3 as one of its dependencies. phpstan 0.11.4 was also directly requested to be installed in a different composer-bin-plugin namespace. Since rector's phpstan was installed first, the link was pointing to the 0.11.3 version instead of 0.11.4 we expected. As a consequence no phpstan plugins could be loaded.