-
-
Notifications
You must be signed in to change notification settings - Fork 27
Add Symplify extensions for Phpstan #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not against it if you think it's well maintained. One thing to consider is the dependencies an extension brings. These might conflict with dependencies on your project. We recently had problems with the larastan extension that locked Symfony components in an older version. I think this is one of the reasons why phpstan's recommended installation method is to include it in your composer file. Before installing the symplify extension: After: |
|
Yes, I was a little concerned about the dependencies when I was putting together the PR. I would say it's well maintained, but regardless all these extra packages could well cause headaches in the future. Maybe in this case it's better to keep this extension out of the package? I can just build it in myself should I want to... Anyway, you're the maintainer - feel free to use the PR or not it was only a few minutes work so doesn't really matter either way. Cheers. |
The Symplify project is from Tomas Votruba who is also the maintainer of RectorPhp and Easy Coding Standard. I feel this extension would be a useful extension to the toolbox.
Feel free to disagree as obviously it can also be installed manually by users that need it.