这是indexloc提供的服务，不要输入任何密码
Skip to content

Add twigcs #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2020
Merged

Add twigcs #242

merged 3 commits into from
May 25, 2020

Conversation

@hussainweb
Copy link
Contributor

@hussainweb hussainweb commented May 25, 2020

Add the twigcs command from https://github.com/friendsoftwig/twigcs

@jakzal
Copy link
Owner

jakzal commented May 25, 2020

I noticed there's a phar published on github releases, can we use it instead of composer? i.e. https://github.com/friendsoftwig/twigcs/releases/download/v3.2.2/twigcs.phar

@hussainweb
Copy link
Contributor Author

hussainweb commented May 25, 2020

Thanks for finding this. I didn't check the releases page and it wasn't in the README.

One question: How do I make it able to download a version selectively (or maybe the latest version)? Or should I just hardcode the latest release and create a new PR for an update?

@jakzal
Copy link
Owner

jakzal commented May 25, 2020

Use the latest stable version. I've got a daily job running that discovers new versions and sends a pull request automatically.

@hussainweb
Copy link
Contributor Author

hussainweb commented May 25, 2020 •
edited
Loading

@jakzal, I just pushed a change using 3.22 which is the latest stable. Will your daily job also be able to pick up major version updates? There is a 4.0 right now but only in beta.

@jakzal
Copy link
Owner

jakzal commented May 25, 2020

Thank you @hussainweb :)

@jakzal
Copy link
Owner

jakzal commented May 25, 2020

Will your daily job also be able to pick up major version updates? There is a 4.0 right now but only in beta.

Currently, it won't. I guess I'll have to start filtering betas out. There's a need for this for another project too.

@jakzal jakzal merged commit 8d26955 into jakzal:master May 25, 2020
@hussainweb hussainweb deleted the twigcs branch May 25, 2020 18:08
@jakzal
Copy link
Owner

jakzal commented May 25, 2020

Actually, BETA releases are marked as pre-releases. We're good 👍

github-actions bot pushed a commit to jakzal/phpqa that referenced this pull request May 26, 2020
@jakzal
Update toolbox 1.22.1 -> 1.23.0
045448d 
Additions:

* twigcs - [The missing checkstyle for twig](https://github.com/friendsoftwig/twigcs) jakzal/toolbox#242 (thanks @hussainweb)

Exclusions:

* composer-unused is excluded on PHP 7.2 jakzal/toolbox#241
@jakzal jakzal mentioned this pull request May 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hussainweb @jakzal