这是indexloc提供的服务，不要输入任何密码
Skip to content

#105 Add Doctrine psalm plugin #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2020
Merged

#105 Add Doctrine psalm plugin #233

merged 1 commit into from
May 10, 2020

Conversation

@githoober
Copy link

@githoober githoober commented May 9, 2020 •
edited
Loading

Fulfills #105

@jakzal jakzal merged commit 5d15395 into jakzal:master May 10, 2020
@jakzal
Copy link
Owner

jakzal commented May 10, 2020

Thank you @githoober 🍺

github-actions bot pushed a commit to jakzal/phpqa that referenced this pull request May 11, 2020
@jakzal
Update toolbox 1.20.1 -> 1.21.0
99db2be 
Additions:

* Add Doctrine psalm plugin jakzal/toolbox#233 thanks @githoober

Updates:

* infection (0.16.2 -> 0.16.3) jakzal/toolbox#219

* deptrac (0.6.0 -> 0.7.1) jakzal/toolbox#221 jakzal/toolbox#222 thanks @smoench
@jakzal jakzal mentioned this pull request May 11, 2020
Merged
@dkarlovi
Copy link
Contributor

dkarlovi commented Jun 20, 2020

How do you actually use this within the Docker image? There doesn't seem to be a psalm-plugin available in the path.

@dkarlovi
Copy link
Contributor

dkarlovi commented Jun 20, 2020

Never mind, I need to run a different copy of Psalm, the one in

/tools/.composer/vendor-bin/doctrine-psalm-plugin/vendor/bin/psalm

The namespace hints you cannot have two plugins installed at the same time? We might want to move it to psalm namespace or something.

@jakzal
Copy link
Owner

jakzal commented Jun 20, 2020

Looking at now I’m not sure why it’s in its own namespace.

@dkarlovi
Copy link
Contributor

dkarlovi commented Jun 20, 2020

I'm fine with each tool being in its own namespace since they're stand-alone from each other, but the plugins should then be in that tool's namespace, not each plugin in its own. The idea here should definitely be the base psalm tool should have access to its plugins.

@jakzal
Copy link
Owner

jakzal commented Jun 22, 2020

@dkarlovi fancy to create a PR?

@dkarlovi
Copy link
Contributor

dkarlovi commented Jun 22, 2020

@jakzal Yes, I'll add Psalm's Symfony and PHPUnit plugins this week so let's fix it all together, if you agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@githoober @jakzal @dkarlovi