install simple-phpunit v9 #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
phpunit 9 won't work on PHP 7.2 |
Contributor
Author
|
i see. i guess it's a bit too early to exclude simple-phpunit as a whole on php72 ... could we somehow conditionally exclude v9? e.g. duplicate the JSON but with different tags ... |
Owner
|
We already do something similar with phpunit (phpunit-5, phpunit-8, phpunit being latest). I'd like to limit the use of this approach to the minimum though. Since PHP 7.2 goes EOL in 4 months I think it's fine to just exclude simple-phpunit from 7.2. People can still use older docker tags to use it the next few months. Also, on user's request, we can bring it back as simple-phpunit-8 when needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8 is now the current default in symfony's bridge: https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/PhpUnit/bin/simple-phpunit.php#L98
v9 is the current stable however