Remove PHP_Testability, DesignPatternDetector #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Can you move it in the README to a new list below the current one? Header can be called something like "Abandoned tools". Let's remove the other one too. They're not really usable. |
Contributor
Author
|
You mean somewhat like a reference changelog of tools once available, but removed meanwhile? Do we want to keep track of that actually.. i.e. why not a release changelog instead? |
Owner
|
Yeah, i just want to keep removed tools on the list, so they could still be found. Some people use this list as a resource of available tools . |
Owner
|
Cheers 🍺 |
jakzal
added a commit
to jakzal/phpqa
that referenced
this pull request
Jul 3, 2019
Updates * phan (2.2.3 -> 2.2.4) jakzal/toolbox#122 Removals: * design-pattern - [Detects design patterns](https://github.com/Halleck45/DesignPatternDetector) jakzal/toolbox#121 * testability - [Analyses and reports testability issues of a php codebase](https://github.com/edsonmedina/php_testability) jakzal/toolbox#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #117
For
halleck45/phpmetrics, it's part of https://github.com/Halleck45/DesignPatternDetectorLast commit 4 years ago, i'm not sure i should open a PR there 😅 do we want to keep it?