这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@Pierstoval
Copy link
Contributor

@Pierstoval Pierstoval commented May 24, 2019

I could not really succeed in testing this, but I guess the format should be right 😄

What I know is that it created the right symlink, and when I executed the binary manually, it worked 👍

Fixes #102

@jakzal
Copy link
Owner

jakzal commented May 29, 2019

It doesn't support php 7.1, so the build is failing: https://travis-ci.com/jakzal/toolbox/jobs/202783687#L666

@jakzal
Copy link
Owner

jakzal commented May 29, 2019

To fix the build please exclude the phpinsights on php 7.1 by tagging it as follows:

{
    ...,
    "tags": ["exclude-php:7.1"]
}

@Pierstoval
Copy link
Contributor Author

Just pushed the change 😄

@jakzal jakzal merged commit 0b63cd7 into jakzal:master May 29, 2019
@jakzal
Copy link
Owner

jakzal commented May 29, 2019

Thank you @Pierstoval 🍺

@Pierstoval Pierstoval deleted the phpinsights branch May 30, 2019 11:24
jakzal added a commit to jakzal/phpqa that referenced this pull request May 30, 2019
New tools:

* phpinsights - [Analyses code quality, style, architecture and complexity](https://phpinsights.com/) jakzal/toolbox#104 (thanks @Pierstoval)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add nunomaduro/phpinsights

2 participants