feat: PHP 8.3 #487
Closed
feat: PHP 8.3 #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ugh... this one's going to be a bit more involved. I think I might need to rip out prophecy and replace it with PHPUnit mocks. |
Contributor
Author
|
I got it partially working locally, but it needs to use yet unreleased packages, moving to PHPUnit mocks is probably for the best long term. |
Owner
|
Prophecy is gone. |
Contributor
Author
|
I just got a notification on my phone saying (without context)
Seemed like Zeus was sending me a text. 🤣 |
Contributor
Author
|
build fails, did you mean to release 2.7.0 here? |
Owner
|
No. Let's drop PHP 8.0 here if it's causing problems. |
Contributor
Author
|
Makes sense, 8.0 is EOL. |
This was referenced Nov 28, 2023
Merged
Contributor
Author
|
Replaced by #493 |
Owner
|
@dkarlovi I had to create a new PR so that builds could use secrets. |
Contributor
Author
|
No problem! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.