这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@whjum
Copy link
Contributor

@whjum whjum commented Mar 13, 2024

This pull request should add the requested feature mentioned in issue #283.

I am not sure whether there will be more than one support formats so I use Enum instead of plain string. Feel free to revert or modify the type to the one fits best for the need.

Thanks for the fast response :)

@j178
Copy link
Owner

j178 commented Mar 13, 2024

Hi, thanks for the PR —it's looking great!

I've gone ahead and refactored it a bit by organizing various formatting codes into dedicated functions. I hope that's okay with you. Thanks again!

@j178 j178 merged commit 4496dc1 into j178:master Mar 13, 2024
@whjum whjum deleted the add-json-output branch March 13, 2024 14:28
@whjum
Copy link
Contributor Author

whjum commented Mar 13, 2024

Looks clean and neat. Thank you for reviewing 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants