Removed Deprecated Code, Added Alamofire and Updated Demo App #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed deprecated code
- Added activity indicator to show loading - Updated constraints - Use primary action to dismiss keyboard
Owner
|
Hi, thank you for the contribution. My apologies for the outdated NSURLConnection, but I'd prefer updating the syntax to match latest Swift version to adding more dependency to the library. What do you think about that? |
Contributor
Author
|
Ok, I've replaced Alamofire with URLSession. |
Owner
|
Looks great! Merging request, thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched it to Alamofire from NSURLConnection
Removed Deprecated Code from NSURLConnection
Updated demo app