fix "Template Not Found" error #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error in which GET requests to /channels/<channel_id>/status.(format) fail with a "Template Not Found" error for JSON, CSV, and XML formats.
The status controller was previously requesting templates from ./app/views/status/feed/index and /app/views/application/feed/index, instead of ./app/views/feed/index. I have never worked in Ruby or with Rails before, so this might be caused by a configuration issue on my end, or there may be a different/preferred syntax for the 'render' calls, but this seems to do the trick.
In order to re-use the feed view with the status controller (as I believe was the intention) , the variable names in the status controller have been updated to match those in the feed controller and the feed templates.
With this patch, the behavior and output of status requests are now the same as api.thingspeak.com.