Fix returning an API Key that was size + 1. #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0..size iterates through size + 1 elements. So asking for an API that was 16 was actually returning a string of 17 characters. This broke trying to shove it into a varchar(16) in PostgreSQL.
iobridge
added a commit
that referenced
this pull request
Apr 21, 2013
PostgreSQL: Fix returning an API Key that was size + 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to create a new channel using PostgreSQL as a database I was getting a database error that api_key's value was too long for type character varying(16).
Looking into the code I found that generate_api_key has an instance of 0..size which iterates through size + 1 elements. So asking for an API Key that was 16 characters long was actually returning a string of 17 characters. This broke trying to shove it into a varchar(16) in PostgreSQL.
This patch ensures that only size characters are returned.