Include custom data in scope sent to rollbar #303
Conversation
|
Hmm, this does not seem to be working correctly. I'll investigate and update when this is ready. |
370e98e to
2bdba4a
Compare
bb9d2cc to
b5df34f
Compare
c9b96f6 to
b5df34f
Compare
|
@gudmundur this is ready for review now. |
gudmundur
left a comment
There was a problem hiding this comment.
Well spotted that we're not passing this on. I've added a couple of minor comments, otherwise LGTM.
.travis.yml
Outdated
| before_script: | ||
| - createdb pliny-gem-test | ||
| before_install: | ||
| - gem update --system |
There was a problem hiding this comment.
Would you mind removing this? This has already been addressed with ae7dc84.
|
|
||
| def fetch_scope(context:, rack_env:) | ||
| scope = {} | ||
| scope = { custom: context } |
There was a problem hiding this comment.
Weakly held opinion, but is there a reason we don't call this context? Does that name hold some significance to Rollbar?
There was a problem hiding this comment.
It does hold significance to rollbar. Outside of the request object, they require data be under a custom key. See https://rollbar.com/docs/api/items_post/.
b5df34f to
67403ac
Compare
|
@gudmundur comments addressed. |
|
@mikehale Cheers! 🍻 |
|
Thanks! |
This includes the provided context in the rollbar scope. Previously the context was ignored and not included in the scope. This is similar to how scope is defined for rails in rollbar: https://rollbar.com/docs/notifier/rollbar-gem/#the-scope