Make pliny compatible with ruby 2.4 #302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cyberdelia @gudmundur Do you know if the loss of 2.2.2 support is going to be a problem for anyone? It seems like Heroku's generally doing a pretty good job of keeping its Ruby stacks up-to-date. |
Member
|
@cyberdelia Mind fixing that one canonical line test this way instead? diff --git a/spec/canonical_log_line_helpers_spec.rb b/spec/canonical_log_line_helpers_spec.rb
index 3509912..0290dec 100644
--- a/spec/canonical_log_line_helpers_spec.rb
+++ b/spec/canonical_log_line_helpers_spec.rb
@@ -22,9 +22,9 @@ describe Pliny::CanonicalLogLineHelpers do
it "rejects values that are of the wrong type" do
line = TestCanonicalLogLine.new
e = assert_raises ArgumentError do
- line.field_string = 42
+ line.field_string = true
end
- assert_equal "Expected field_string to be type String (was Fixnum)",
+ assert_equal "Expected field_string to be type String (was TrueClass)",
e.message
endI think it's a little less janky because it's version agnostic. Thanks! |
Member
Author
|
@brandur I did just that. |
Member
|
Sweet! Well, as long as we're reasonably sure we're not going to leave too many people around by dropping 2.1, LGTM. |
Member
|
Did a quick search through the Heroku repos and most Ruby projects seem to be 2.3+. I'm bringing this in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to run Pliny with ruby 2.4 by upgrading the
activesupportgem, since it requires a version of thejsongem that is incompatible with ruby 2.4.Sadly this also means we have to drop support for ruby > 2.2.2 since
activesupportdo not support them.