Add arity and timings for serializers to canonical log lines #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandur
reviewed
Feb 20, 2017
lib/pliny/helpers/serialize.rb
Outdated
| end | ||
|
|
||
| self.class.serializer_class.new(structure).serialize(data) | ||
| env['serialization_arity'] = data.respond_to?(:size) ? data.size : 1 |
Member
There was a problem hiding this comment.
Can we do pliny.serialization_arity for good env hygiene?
brandur
reviewed
Feb 20, 2017
Member
brandur
left a comment
There was a problem hiding this comment.
Nice! And yeah, unfortunately I think the env is the way to go here, although my prefixing things in there we can keep it relatively well organized.
What do you think about a test on a serializer class just to verify that emits information into env in order to fulfill its contract with the log line middleware?
lib/pliny/helpers/serialize.rb
Outdated
|
|
||
| start = Time.now | ||
| serializer_class.new(structure).serialize(data).tap do | ||
| env['timing_serialization'] = (Time.now - start).to_f |
Member
There was a problem hiding this comment.
And maybe pliny.serialization_timing here. We can flip the words back around when adding it to the log line.
Member
Author
|
@brandur updated. |
Member
|
Thanks! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
serialization_arityandtiming_serializationto the canonical log line. I find it a little strange storing this inenv[], but don't really have better suggestions.