Handle a JSON Array of params #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
396771f to
61ae81a
Compare
Back in e3da8c9 we started using Sinatra::IndifferentHash for Sinatra v2+, but didn't handle the case of a JSON array being passed as the root element. The older `#indifferent_params` from Sinatra v1 did handle this case. We've roughly re-created that here, though we're a little more permissive in that we allow for things that are Hash-like (via #to_hash) and Array-like (via #to_ary) rather than relying on type.
61ae81a to
86d6810
Compare
ransombriggs
suggested changes
Jan 15, 2020
ransombriggs
left a comment
There was a problem hiding this comment.
@stevenharman I would prefer to use the implementation from sinatra to avoid any unintended effects of having a more permissive implementation.
ransombriggs
suggested changes
Jan 15, 2020
The original Sinatra v1 implementation was more restrictive, relying on explicit type-checking to determine how to convert params. To be safe, we'll do the same. And in effect, b/c we're always dealing with JSON-decoded data here, we'd not expect to see something other than Hash or Array.
5c0625e to
50d50cd
Compare
ransombriggs
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back in #317 we started using
Sinatra::IndifferentHashfor Sinatra v2+, but didn't handle the case of a JSON array being passed as the root element. The older#indifferent_paramsfrom Sinatra v1 did handle this case. We've roughly re-created that here, though we're a little more permissive in that we allow for things that are Hash-like (via#to_hash) and Array-like (via#to_ary) rather than relying on type.