这是indexloc提供的服务，不要输入任何密码
Skip to content

Add mechanism for additional headers. #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2017
Merged

Add mechanism for additional headers. #320

merged 1 commit into from
Dec 4, 2017

Conversation

@bigkevmcd
Copy link
Contributor

@bigkevmcd bigkevmcd commented Nov 30, 2017

To add additional headers to responses, we have to resort to something like...

allowed_cors_headers = Pliny::Middleware::CORS.send(:remove_const, :ALLOW_HEADERS).dup
allowed_cors_headers << "X-Origin"

Pliny::Middleware::CORS::ALLOW_HEADERS = allowed_cors_headers.freeze

It'd be nice if we could just configure the response headers globally when configuring our app?

raulb
raulb reviewed Nov 30, 2017
View reviewed changes
lib/pliny/middleware/cors.rb Outdated
end

def allow_headers
ALLOW_METHODS + @@additional_headers
Copy link

@raulb raulb Nov 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ALLOW_METHODS/ALLOW_HEADERS

@gudmundur
Copy link
Member

gudmundur commented Dec 4, 2017

Nicely done. I'm glad to see this contribution as the example you gave is something that's made my eyes all teary a few times. 😢

@gudmundur gudmundur merged commit 26eef13 into interagent:master Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@raulb raulb raulb left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bigkevmcd @gudmundur @raulb