-
Notifications
You must be signed in to change notification settings - Fork 238
chore: remove go-ethereum replace #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request updates the ledger integration by changing the ledger derivation assignment in the keyring options and restructuring the package organization. New account management functionalities are added, including Ethereum account structures, HD wallet derivation, URL parsing, and dedicated error types with tests. Package names and import paths have been revised (from Changes
Sequence Diagram(s)sequenceDiagram
participant Hub as USB Wallet Hub
participant Driver as Ledger Driver
participant Device as USB Device
participant App as Wallet App
Hub->>Device: Scan for connected hardware wallets
Device-->>Hub: Return device list
Hub->>Driver: Initialize connection with device
Driver->>Device: Open connection
Device-->>Driver: Connection established
Driver->>Driver: Retrieve status & version
Driver-->>Hub: Return wallet info
Hub->>App: Notify wallet event subscription update
sequenceDiagram
participant App as Wallet App
participant Wallet as USB Wallet
participant Driver as Ledger Driver
participant Device as USB Device
App->>Wallet: Request to sign transaction
Wallet->>Driver: Call SignTx with derivation path and tx
Driver->>Device: Send APDU command for transaction signing
Device-->>Driver: Return signature
Driver->>Wallet: Return signed transaction
Wallet-->>App: Deliver signed transaction
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (13)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #368 +/- ##
==========================================
- Coverage 41.17% 39.94% -1.23%
==========================================
Files 270 277 +7
Lines 25826 26863 +1037
==========================================
+ Hits 10634 10731 +97
- Misses 13536 14473 +937
- Partials 1656 1659 +3
🚀 New features to boost your workflow:
|
Description
remove replace but add packages on initia
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...