这是indexloc提供的服务,不要输入任何密码
Skip to content

chore: remove go-ethereum replace #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

chore: remove go-ethereum replace #368

merged 1 commit into from
Mar 13, 2025

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Mar 13, 2025

Description

remove replace but add packages on initia

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 self-assigned this Mar 13, 2025
@beer-1 beer-1 requested a review from a team as a code owner March 13, 2025 02:45
Copy link

coderabbitai bot commented Mar 13, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request updates the ledger integration by changing the ledger derivation assignment in the keyring options and restructuring the package organization. New account management functionalities are added, including Ethereum account structures, HD wallet derivation, URL parsing, and dedicated error types with tests. Package names and import paths have been revised (from keyring to ledger), and comprehensive USB wallet support is introduced with drivers, hub, and wallet implementations to manage Ledger/Trezor hardware wallets.

Changes

File(s) Change Summary
crypto/keyring/options.go Updated import to "github.com/initia-labs/initia/crypto/ledger" and changed LedgerDerivation assignment from LedgerDerivationFn() to ledger.LedgerDerivationFn().
crypto/ledger/accounts/... (account.go, errors.go, hd.go, hd_test.go, url.go, url_test.go) Added new structures and interfaces for Ethereum account and wallet management, including HD derivation paths, URL parsing, error definitions, and corresponding tests.
crypto/ledger/ledger{,.mock.go,.notavail.go} Renamed package from keyring to ledger and updated import paths for accounts and usbwallet packages.
crypto/ledger/usbwallet/... (hub.go, ledger.go, wallet.go) Introduced USB wallet support with implementations for hardware wallet discovery, Ledger driver functionalities, and comprehensive wallet management methods.

Sequence Diagram(s)

sequenceDiagram
    participant Hub as USB Wallet Hub
    participant Driver as Ledger Driver
    participant Device as USB Device
    participant App as Wallet App

    Hub->>Device: Scan for connected hardware wallets
    Device-->>Hub: Return device list
    Hub->>Driver: Initialize connection with device
    Driver->>Device: Open connection
    Device-->>Driver: Connection established
    Driver->>Driver: Retrieve status & version
    Driver-->>Hub: Return wallet info
    Hub->>App: Notify wallet event subscription update
Loading
sequenceDiagram
    participant App as Wallet App
    participant Wallet as USB Wallet
    participant Driver as Ledger Driver
    participant Device as USB Device

    App->>Wallet: Request to sign transaction
    Wallet->>Driver: Call SignTx with derivation path and tx
    Driver->>Device: Send APDU command for transaction signing
    Device-->>Driver: Return signature
    Driver->>Wallet: Return signed transaction
    Wallet-->>App: Deliver signed transaction
Loading

Possibly related PRs

Suggested reviewers

  • sh-cha

Poem

Hoppin’ through the code, I twirl and spin,
Ledger paths and error hops, a joyous din.
USB buds and hardware thrills so keen,
Accounts and keys in every scene.
With carrot beats and ASCII gleams,
A rabbit’s code celebrates bright new dreams! 🐰🥕

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3f57d44 and 09917f6.

⛔ Files ignored due to path filters (2)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum, !**/*.sum
📒 Files selected for processing (13)
  • crypto/keyring/options.go (2 hunks)
  • crypto/ledger/accounts/account.go (1 hunks)
  • crypto/ledger/accounts/errors.go (1 hunks)
  • crypto/ledger/accounts/hd.go (1 hunks)
  • crypto/ledger/accounts/hd_test.go (1 hunks)
  • crypto/ledger/accounts/url.go (1 hunks)
  • crypto/ledger/accounts/url_test.go (1 hunks)
  • crypto/ledger/ledger.go (2 hunks)
  • crypto/ledger/ledger_mock.go (1 hunks)
  • crypto/ledger/ledger_notavail.go (1 hunks)
  • crypto/ledger/usbwallet/hub.go (1 hunks)
  • crypto/ledger/usbwallet/ledger.go (1 hunks)
  • crypto/ledger/usbwallet/wallet.go (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@beer-1 beer-1 merged commit cc98a53 into main Mar 13, 2025
6 of 7 checks passed
@beer-1 beer-1 deleted the feat/evm-replace branch March 13, 2025 02:46
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 9.34489% with 941 lines in your changes missing coverage. Please review.

Project coverage is 39.94%. Comparing base (e9fea87) to head (09917f6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crypto/ledger/usbwallet/wallet.go 0.00% 413 Missing ⚠️
crypto/ledger/usbwallet/ledger.go 0.00% 317 Missing ⚠️
crypto/ledger/usbwallet/hub.go 0.00% 169 Missing ⚠️
crypto/ledger/accounts/hd.go 82.14% 14 Missing and 1 partial ⚠️
crypto/ledger/accounts/url.go 70.00% 10 Missing and 2 partials ⚠️
crypto/ledger/accounts/account.go 0.00% 8 Missing ⚠️
crypto/ledger/accounts/errors.go 0.00% 6 Missing ⚠️
crypto/keyring/options.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   41.17%   39.94%   -1.23%     
==========================================
  Files         270      277       +7     
  Lines       25826    26863    +1037     
==========================================
+ Hits        10634    10731      +97     
- Misses      13536    14473     +937     
- Partials     1656     1659       +3     
Files with missing lines Coverage Δ
crypto/ledger/ledger_mock.go 0.00% <ø> (ø)
crypto/keyring/options.go 0.00% <0.00%> (ø)
crypto/ledger/accounts/errors.go 0.00% <0.00%> (ø)
crypto/ledger/accounts/account.go 0.00% <0.00%> (ø)
crypto/ledger/accounts/url.go 70.00% <70.00%> (ø)
crypto/ledger/accounts/hd.go 82.14% <82.14%> (ø)
crypto/ledger/usbwallet/hub.go 0.00% <0.00%> (ø)
crypto/ledger/usbwallet/ledger.go 0.00% <0.00%> (ø)
crypto/ledger/usbwallet/wallet.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant