这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@GantMan
Copy link
Member

@GantMan GantMan commented Aug 17, 2018

For some reason, both Java and Python would output their versions poorly.

Fixed up Regex to handle the new java mess, and fixed up both to read from STDERR

@codecov
Copy link

codecov bot commented Aug 17, 2018

Codecov Report

Merging #219 into master will increase coverage by 0.11%.
The diff coverage is 45.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #219      +/-   ##
==========================================
+ Coverage   82.08%   82.19%   +0.11%     
==========================================
  Files          34       35       +1     
  Lines         692      702      +10     
  Branches      135      137       +2     
==========================================
+ Hits          568      577       +9     
+ Misses         80       79       -1     
- Partials       44       46       +2
Impacted Files Coverage Δ
src/extensions/functions/getSolidarityHelpers.ts 83.78% <ø> (ø) ⬆️
src/extensions/functions/getVersion.ts 82.35% <0%> (+18.06%) ⬆️
...extensions/functions/removeNonVersionCharacters.ts 100% <100%> (ø) ⬆️
src/extensions/functions/checkSTDERR.ts 57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 060f6dd...4fdc0fb. Read the comment docs.

@GantMan GantMan merged commit 31eb84c into master Aug 17, 2018
@GantMan GantMan deleted the fixup_java_python branch August 17, 2018 03:45
@GantMan GantMan mentioned this pull request Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants