这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@GantMan
Copy link
Member

@GantMan GantMan commented Aug 10, 2018

solidarity --stack react-native

Closes #213

@GantMan GantMan requested a review from jamonholmgren August 10, 2018 22:00
@avaGitHubBot
Copy link

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock - Perhaps you need to run yarn install?

Typos for cliOptions.md

Line Typo
40 ## solidarityFile (-f)
48 arity file in the root of the npm package smoothReporter inst
Got false positives?

Make changes to this repo's settings in spellcheck.json.

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #214 into master will decrease coverage by 0.26%.
The diff coverage is 86.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   82.34%   82.08%   -0.27%     
==========================================
  Files          33       34       +1     
  Lines         657      692      +35     
  Branches      122      135      +13     
==========================================
+ Hits          541      568      +27     
- Misses         78       80       +2     
- Partials       38       44       +6
Impacted Files Coverage Δ
src/extensions/functions/updateVersions.ts 88.23% <100%> (ø) ⬆️
src/commands/help.ts 100% <100%> (ø) ⬆️
src/commands/solidarity.ts 47.82% <100%> (ø) ⬆️
src/commands/report.ts 75% <100%> (ø) ⬆️
src/commands/create.ts 100% <100%> (ø) ⬆️
...c/extensions/functions/buildSpecificRequirement.ts 95% <100%> (ø) ⬆️
...c/extensions/functions/appendSolidaritySettings.ts 100% <100%> (ø) ⬆️
src/commands/snapshot.ts 36.17% <100%> (+1.38%) ⬆️
src/extensions/functions/getSolidaritySettings.ts 85% <80%> (-10.84%) ⬇️
src/extensions/functions/getSolidarityHelpers.ts 83.78% <83.78%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a73fdb0...7528f33. Read the comment docs.

@GantMan GantMan merged commit 64fce79 into master Aug 11, 2018
@GantMan GantMan deleted the check-option branch August 11, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants