这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@jamonholmgren
Copy link
Member

Mostly bugfixes.

@jamonholmgren jamonholmgren requested a review from GantMan May 11, 2018 19:30
@TravisBuddy
Copy link
Contributor

Hey @jamonholmgren,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

1 similar comment
@TravisBuddy
Copy link
Contributor

Hey @jamonholmgren,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because something unrelated to the tests, like a problem a dependency or the build process itself.

@jamonholmgren
Copy link
Member Author

@jamonholmgren
Copy link
Member Author

Pushing up commit that should resolve these issues.

@codecov
Copy link

codecov bot commented May 17, 2018

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files          33       33           
  Lines         657      657           
  Branches      122      122           
=======================================
  Hits          541      541           
  Misses         78       78           
  Partials       38       38

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32a8097...275ddb1. Read the comment docs.

@GantMan
Copy link
Member

GantMan commented May 17, 2018

The spinner seems to have issues when there are follow up spins.
image

image

Otherwise the spinner alone works great.

@jamonholmgren jamonholmgren force-pushed the upgrade/gluegun-2.0.0-beta.11 branch from 05243af to 275ddb1 Compare May 17, 2018 20:48
@GantMan GantMan merged commit a73fdb0 into master May 17, 2018
@GantMan GantMan deleted the upgrade/gluegun-2.0.0-beta.11 branch May 17, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants