这是indexloc提供的服务，不要输入任何密码
Skip to content

attempt path change for windows #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2018
Merged

attempt path change for windows #201

merged 2 commits into from
Apr 4, 2018

Conversation

@GantMan
Copy link
Member

@GantMan GantMan commented Apr 4, 2018

No description provided.

@TravisBuddy
Copy link
Contributor

TravisBuddy commented Apr 4, 2018

Travis tests have failed

Hey @GantMan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

yarn danger ci 
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
The DANGER_GITHUB_API_TOKEN environmental variable is missing
Without an api token, danger will be unable to comment on a PR
Error:  Error: Cannot use authenticated API requests.
    at Object.getPlatformForEnv (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/platforms/platform.js:16:15)
    at Object.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:68:70)
    at step (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:32:23)
    at Object.next (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:13:53)
    at fulfilled (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
    at Function.Module.runMain (module.js:695:11)
    at startup (bootstrap_node.js:188:16)
    at bootstrap_node.js:609:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@codecov
Copy link

codecov bot commented Apr 4, 2018

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   82.38%   82.38%           
=======================================
  Files          33       33           
  Lines         653      653           
  Branches      120      120           
=======================================
  Hits          538      538           
  Misses         78       78           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8345148...31e0a1f. Read the comment docs.

@TravisBuddy
Copy link
Contributor

TravisBuddy commented Apr 4, 2018

Travis tests have failed

Hey @GantMan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 8

yarn danger ci 
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
The DANGER_GITHUB_API_TOKEN environmental variable is missing
Without an api token, danger will be unable to comment on a PR
Error:  Error: Cannot use authenticated API requests.
    at Object.getPlatformForEnv (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/platforms/platform.js:16:15)
    at Object.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:68:70)
    at step (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:32:23)
    at Object.next (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:13:53)
    at fulfilled (/home/travis/build/infinitered/solidarity/node_modules/danger/distribution/commands/ci/runner.js:4:58)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
    at Function.Module.runMain (module.js:695:11)
    at startup (bootstrap_node.js:188:16)
    at bootstrap_node.js:609:3
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@TravisBuddy
Copy link
Contributor

TravisBuddy commented Apr 4, 2018

Travis tests have failed

Hey @GantMan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci 
> solidarity@2.0.5 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

 PASS  __tests__/commands/snapshot.ts
 PASS  __tests__/command_helpers/checkRequirement.ts
 PASS  __tests__/command_helpers/updateRequirement.ts
 PASS  __tests__/command_helpers/getSolidaritySettings.ts
 PASS  __tests__/command_helpers/reviewRule.ts
 PASS  __tests__/command_helpers/appendSolidaritySettings.ts
 PASS  __tests__/command_helpers/checkShell.ts
 PASS  __tests__/integration/solidarity-check/check-valid.ts (6.423s)
 PASS  __tests__/command_helpers/checkRequirementPlugins.ts
 PASS  __tests__/commands/solidarity.ts
 PASS  __tests__/command_helpers/checkCLIForUpdates.ts
 PASS  __tests__/command_helpers/createPlugin.ts
 PASS  __tests__/command_helpers/checkCLI.ts
 PASS  __tests__/command_helpers/getVersion.ts
 PASS  __tests__/command_helpers/quirksNodeModules.ts
 PASS  __tests__/command_helpers/printResults.ts
 PASS  __tests__/command_helpers/removeNonVersionCharacters.ts
 PASS  __tests__/command_helpers/updateVersions.ts
 PASS  __tests__/commands/create.ts
 PASS  __tests__/integration/solidarity-report/report-basic.ts
 PASS  __tests__/command_helpers/findPluginInfo.ts
 PASS  __tests__/command_helpers/getLineWithVersion.ts
 PASS  __tests__/command_helpers/skipRule.ts
 PASS  __tests__/extensions/extensionCheck.ts
 PASS  __tests__/index.ts
 PASS  __tests__/commands/help.ts
 PASS  __tests__/integration/solidarity-snapshot/snapshot-nada.ts
 PASS  __tests__/command_helpers/checkENV.ts
 PASS  __tests__/command_helpers/checkDir.ts
 PASS  __tests__/command_helpers/checkFile.ts
 PASS  __tests__/command_helpers/setSolidaritySettings.ts
 PASS  __tests__/integration/solidarity-check/check-invalid.ts
 PASS  __tests__/command_helpers/solidarityReport.ts
 PASS  __tests__/commands/report.ts
 PASS  __tests__/docs/testDocs.ts
 PASS  __tests__/command_helpers/binaryExists.ts
 PASS  __tests__/schema/validateExampleSchema.ts

Test Suites: 37 passed, 37 total
Tests:       173 passed, 173 total
Snapshots:   43 passed, 43 total
Time:        26.508s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/

Node.js: 8

npm run test:ci 
> solidarity@2.0.5 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

 PASS  __tests__/commands/snapshot.ts
 PASS  __tests__/command_helpers/checkRequirement.ts
 PASS  __tests__/command_helpers/updateRequirement.ts
 PASS  __tests__/command_helpers/getSolidaritySettings.ts
 PASS  __tests__/command_helpers/reviewRule.ts
 PASS  __tests__/command_helpers/appendSolidaritySettings.ts
 PASS  __tests__/command_helpers/checkShell.ts
 PASS  __tests__/integration/solidarity-check/check-valid.ts (5.162s)
 PASS  __tests__/command_helpers/checkRequirementPlugins.ts
 PASS  __tests__/commands/solidarity.ts
 PASS  __tests__/command_helpers/checkCLIForUpdates.ts
 PASS  __tests__/command_helpers/createPlugin.ts
 PASS  __tests__/command_helpers/checkCLI.ts
 PASS  __tests__/command_helpers/getVersion.ts
 PASS  __tests__/command_helpers/quirksNodeModules.ts
 PASS  __tests__/command_helpers/printResults.ts
 PASS  __tests__/command_helpers/removeNonVersionCharacters.ts
 PASS  __tests__/command_helpers/updateVersions.ts
 PASS  __tests__/commands/create.ts
 PASS  __tests__/integration/solidarity-report/report-basic.ts
 PASS  __tests__/command_helpers/findPluginInfo.ts
 PASS  __tests__/command_helpers/getLineWithVersion.ts
 PASS  __tests__/command_helpers/skipRule.ts
 PASS  __tests__/extensions/extensionCheck.ts
 PASS  __tests__/integration/solidarity-snapshot/snapshot-nada.ts
 PASS  __tests__/command_helpers/checkENV.ts

@GantMan GantMan merged commit 272ad51 into master Apr 4, 2018
@GantMan GantMan deleted the fix_windows_path branch April 4, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GantMan @TravisBuddy