这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@tabrindle
Copy link
Contributor

No description provided.

@avaGitHubBot
Copy link

Warnings
⚠️

Changes were made to package.json, but not to package-lock.json - Perhaps you need to run npm install?

Generated by 🚫 dangerJS

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #229 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   82.26%   82.31%   +0.05%     
==========================================
  Files          35       35              
  Lines         705      707       +2     
  Branches      138      138              
==========================================
+ Hits          580      582       +2     
  Misses         79       79              
  Partials       46       46
Impacted Files Coverage Δ
src/extensions/solidarity-extension.ts 86.66% <100%> (ø) ⬆️
src/extensions/functions/solidarityReport.ts 90.9% <100%> (+2.02%) ⬆️
src/commands/report.ts 75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966d11f...16b8d26. Read the comment docs.

Copy link
Member

@GantMan GantMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@GantMan
Copy link
Member

GantMan commented Nov 6, 2018

@tabrindle - can I beg you to do a once over in the plugin too?

https://github.com/GantMan/solidarity-envinfo

@GantMan GantMan merged commit ae02cbf into master Nov 6, 2018
@GantMan GantMan deleted the chore/upgrade-envinfo-5.12.0 branch November 6, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants