这是indexloc提供的服务，不要输入任何密码
Skip to content

Refactored combined use of await and .then to use await only #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Refactored combined use of await and .then to use await only #225

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a72e83c
Refactored combined use of await and .then to use await only.
taylanken Oct 1, 2018
0a76334
Removed an unnecessary semicolon
taylanken Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 14 additions & 15 deletions src/extensions/functions/updateVersions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,19 +15,18 @@ module.exports = async (context: SolidarityRunContext): Promise<void> => {
)

// run the array of promises you just created
await Promise.all(checks)
.then(results => {
const updates = flatten(results)
if (isEmpty(updates)) {
print.success('\n No Changes')
} else {
setSolidaritySettings(solidaritySettings, context)
const ruleMessage = pluralize('Rule', updates.length, true)
print.success(`\n ${ruleMessage} updated`)
}
})
.catch(err => {
print.error(err)
process.exit(2)
})
try {
const results = await Promise.all(checks)
const updates = flatten(results)
if (isEmpty(updates)) {
print.success('\n No Changes')
} else {
setSolidaritySettings(solidaritySettings, context)
const ruleMessage = pluralize('Rule', updates.length, true)
print.success(`\n ${ruleMessage} updated`)
}
} catch (err) {
print.error(err)
process.exit(2)
}
}