Add yarn path for plugin check #222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GantMan
reviewed
Aug 30, 2018
src/index.ts
Outdated
| .plugins('./node_modules', { matching: 'solidarity-*', hidden: true }) | ||
| // global installs | ||
| .plugins('/usr/local/lib/node_modules', { matching: 'solidarity-*', hidden: true }) // Darwin | ||
| .plugins(`${__dirname}/../..`, { matching: 'solidarity-*', hidden: true }) // Yarn/Darwin |
Member
There was a problem hiding this comment.
This is an interesting solution. What about this?
https://stackoverflow.com/questions/9080085/node-js-find-home-directory-in-platform-agnostic-way
Member
|
Also, tests need to be updated. |
cbc0024 to
da811b8
Compare
Contributor
Author
|
@GantMan : I keep getting |
Member
|
Not sure on your error, but everything looks good. For some reason Danger is failing on travis. I might remove it for now. Good work bud! gonna merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried it out by playing in
~/.config/yarn/global/node_modules/solidarity/dist/index.js.Seems to work out.
I first tried to put
~/.config/yarn/global/node_modules, but this did not work (I guess~might not be the current user whennoderuns?)Tentatively closes #221