feat: inject versions into friendly errors #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 80.76% 80.88% +0.12%
==========================================
Files 33 33
Lines 629 633 +4
Branches 108 111 +3
==========================================
+ Hits 508 512 +4
Misses 83 83
Partials 38 38
Continue to review full report at Codecov.
|
GantMan
reviewed
Mar 30, 2018
| binarySemantic += '.0' | ||
| } | ||
|
|
||
| const customMessage = (rule.error || '') |
Member
There was a problem hiding this comment.
you're one of the few people I know who knows emptystring evaluates as falsy.
GantMan
approved these changes
Mar 30, 2018
Member
GantMan
left a comment
There was a problem hiding this comment.
works for me! Thanks so much @tabrindle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In your error message, you can include
{{wantedVersion}}and{{installedVersion}}to give the user version information, or even to customize scripts to help them install or update.