✨ Fixups for new version #180

GantMan · 2018-03-02T04:54:17Z

Adding more tests, and improving error reporting.

TravisBuddy · 2018-03-02T04:55:55Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.1 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/checkRequirementPlugins.ts
FAIL __tests__/integration/solidarity-check/check-valid.ts (6.658s)
  ● default looks for .solidarity file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |   process.chdir(tempDir)
      24 |   try {
    > 25 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      26 |     done()
      27 |   } catch (err) {
      28 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:25:59)

  ● also looks for .solidarity.json file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      35 |   process.chdir(tempDir)
      36 |   try {
    > 37 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      38 |     done()
      39 |   } catch (err) {
      40 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:37:59)

  ● verbose flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --verbose",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --verbose",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      44 | test('verbose flag works', async done => {
      45 |   try {
    > 46 |     await execa(SOLIDARITY, ['--verbose']).then(result => expect(result).toMatchSnapshot())
      47 |     done()
      48 |   } catch (err) {
      49 |     const x = err
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:46:74)

  ● silent flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --silent",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --silent",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      54 | test('silent flag works', async done => {
      55 |   try {
    > 56 |     await execa(SOLIDARITY, ['--silent']).then(result => expect(result).toMatchSnapshot())
      57 |     done()
      58 |   } catch (err) {
      59 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:56:73)

 › 4 snapshot tests failed.
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/quirksNodeModules.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/commands/create.ts
PASS __tests__/command_helpers/findPluginInfo.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/integration/solidarity-report/report-basic.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/command_helpers/checkDir.ts
FAIL __tests__/integration/solidarity-snapshot/snapshot-nada.ts
  ● solidarity report works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/bin/sh -c echo n | /Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity snapshot",
    +   "cmd": "/bin/sh -c echo n | /home/travis/build/infinitered/solidarity/bin/solidarity snapshot",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |     execa.shell(`echo n | ${SOLIDARITY} snapshot`).then(result => {
      24 |       // check a few from the report
    > 25 |       expect(result).toMatchSnapshot()
      26 |       expect(result.code).toBe(0)
      27 |       done()
      28 |     })
      
      at _execa2.default.shell.then.result (__tests__/integration/solidarity-snapshot/snapshot-nada.ts:25:22)

 › 1 snapshot test failed.
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/solidarityReport.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/createPlugin.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/schema/validateExampleSchema.ts

Summary of all failing tests
FAIL __tests__/integration/solidarity-check/check-valid.ts (6.658s)
  ● default looks for .solidarity file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |   process.chdir(tempDir)
      24 |   try {
    > 25 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      26 |     done()
      27 |   } catch (err) {
      28 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:25:59)

  ● also looks for .solidarity.json file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      35 |   process.chdir(tempDir)
      36 |   try {
    > 37 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      38 |     done()
      39 |   } catch (err) {
      40 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:37:59)

  ● verbose flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --verbose",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --verbose",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      44 | test('verbose flag works', async done => {
      45 |   try {
    > 46 |     await execa(SOLIDARITY, ['--verbose']).then(result => expect(result).toMatchSnapshot())
      47 |     done()
      48 |   } catch (err) {
      49 |     const x = err
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:46:74)

  ● silent flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --silent",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --silent",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      54 | test('silent flag works', async done => {
      55 |   try {
    > 56 |     await execa(SOLIDARITY, ['--silent']).then(result => expect(result).toMatchSnapshot())
      57 |     done()
      58 |   } catch (err) {
      59 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:56:73)

FAIL __tests__/integration/solidarity-snapshot/snapshot-nada.ts
  ● solidarity report works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/bin/sh -c echo n | /Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity snapshot",
    +   "cmd": "/bin/sh -c echo n | /home/travis/build/infinitered/solidarity/bin/solidarity snapshot",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |     execa.shell(`echo n | ${SOLIDARITY} snapshot`).then(result => {
      24 |       // check a few from the report
    > 25 |       expect(result).toMatchSnapshot()
      26 |       expect(result.code).toBe(0)
      27 |       done()
      28 |     })
      
      at _execa2.default.shell.then.result (__tests__/integration/solidarity-snapshot/snapshot-nada.ts:25:22)


Snapshot Summary
 › 5 snapshot tests failed in 2 test suites. Inspect your code changes or run `npm run test:ci -- -u` to update them.

Test Suites: 2 failed, 35 passed, 37 total
Tests:       5 failed, 155 passed, 160 total
Snapshots:   5 failed, 40 passed, 45 total
Time:        24.554s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.1 test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.1 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-03-02T04_55_41_708Z-debug.log

yarn danger ci

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
No issues or messages were sent. Removing any existing messages.
Done in 2.68s.

Node.js: 8

npm run test:ci

> solidarity@1.1.1 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/checkRequirementPlugins.ts
FAIL __tests__/integration/solidarity-check/check-valid.ts (7.223s)
  ● default looks for .solidarity file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |   process.chdir(tempDir)
      24 |   try {
    > 25 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      26 |     done()
      27 |   } catch (err) {
      28 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:25:59)

  ● also looks for .solidarity.json file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      35 |   process.chdir(tempDir)
      36 |   try {
    > 37 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      38 |     done()
      39 |   } catch (err) {
      40 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:37:59)

  ● verbose flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --verbose",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --verbose",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      44 | test('verbose flag works', async done => {
      45 |   try {
    > 46 |     await execa(SOLIDARITY, ['--verbose']).then(result => expect(result).toMatchSnapshot())
      47 |     done()
      48 |   } catch (err) {
      49 |     const x = err
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:46:74)

  ● silent flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --silent",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --silent",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      54 | test('silent flag works', async done => {
      55 |   try {
    > 56 |     await execa(SOLIDARITY, ['--silent']).then(result => expect(result).toMatchSnapshot())
      57 |     done()
      58 |   } catch (err) {
      59 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:56:73)

 › 4 snapshot tests failed.
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/quirksNodeModules.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/commands/create.ts
PASS __tests__/command_helpers/findPluginInfo.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/integration/solidarity-report/report-basic.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/command_helpers/checkDir.ts
FAIL __tests__/integration/solidarity-snapshot/snapshot-nada.ts
  ● solidarity report works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/bin/sh -c echo n | /Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity snapshot",
    +   "cmd": "/bin/sh -c echo n | /home/travis/build/infinitered/solidarity/bin/solidarity snapshot",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |     execa.shell(`echo n | ${SOLIDARITY} snapshot`).then(result => {
      24 |       // check a few from the report
    > 25 |       expect(result).toMatchSnapshot()
      26 |       expect(result.code).toBe(0)
      27 |       done()
      28 |     })
      
      at _execa2.default.shell.then.result (__tests__/integration/solidarity-snapshot/snapshot-nada.ts:25:22)

 › 1 snapshot test failed.
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/solidarityReport.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/createPlugin.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/schema/validateExampleSchema.ts

Summary of all failing tests
FAIL __tests__/integration/solidarity-check/check-valid.ts (7.223s)
  ● default looks for .solidarity file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |   process.chdir(tempDir)
      24 |   try {
    > 25 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      26 |     done()
      27 |   } catch (err) {
      28 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:25:59)

  ● also looks for .solidarity.json file

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      35 |   process.chdir(tempDir)
      36 |   try {
    > 37 |     await execa(SOLIDARITY).then(result => expect(result).toMatchSnapshot())
      38 |     done()
      39 |   } catch (err) {
      40 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:37:59)

  ● verbose flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --verbose",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --verbose",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      44 | test('verbose flag works', async done => {
      45 |   try {
    > 46 |     await execa(SOLIDARITY, ['--verbose']).then(result => expect(result).toMatchSnapshot())
      47 |     done()
      48 |   } catch (err) {
      49 |     const x = err
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:46:74)

  ● silent flag works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity --silent",
    +   "cmd": "/home/travis/build/infinitered/solidarity/bin/solidarity --silent",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      54 | test('silent flag works', async done => {
      55 |   try {
    > 56 |     await execa(SOLIDARITY, ['--silent']).then(result => expect(result).toMatchSnapshot())
      57 |     done()
      58 |   } catch (err) {
      59 |     done.fail()
      
      at then.result (__tests__/integration/solidarity-check/check-valid.ts:56:73)

FAIL __tests__/integration/solidarity-snapshot/snapshot-nada.ts
  ● solidarity report works

    expect(value).toMatchSnapshot()
    
    Received value does not match stored snapshot 1.
    
    - Snapshot
    + Received
    
    @@ -1,7 +1,7 @@
      Object {
    -   "cmd": "/bin/sh -c echo n | /Users/gantman/Documents/Projects/js/rn/node_packages/solidarity/bin/solidarity snapshot",
    +   "cmd": "/bin/sh -c echo n | /home/travis/build/infinitered/solidarity/bin/solidarity snapshot",
        "code": 0,
        "failed": false,
        "killed": false,
        "signal": null,
        "stderr": "",

      23 |     execa.shell(`echo n | ${SOLIDARITY} snapshot`).then(result => {
      24 |       // check a few from the report
    > 25 |       expect(result).toMatchSnapshot()
      26 |       expect(result.code).toBe(0)
      27 |       done()
      28 |     })
      
      at _execa2.default.shell.then.result (__tests__/integration/solidarity-snapshot/snapshot-nada.ts:25:22)


Snapshot Summary
 › 5 snapshot tests failed in 2 test suites. Inspect your code changes or run `npm run test:ci -- -u` to update them.

Test Suites: 2 failed, 35 passed, 37 total
Tests:       5 failed, 155 passed, 160 total
Snapshots:   5 failed, 40 passed, 45 total
Time:        34.624s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.1 test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.1 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-03-02T04_55_46_737Z-debug.log

yarn danger ci

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
No issues or messages were sent. Removing any existing messages.
Done in 2.67s.

codecov · 2018-03-02T05:18:09Z

Codecov Report

Merging #180 into master will decrease coverage by 0.33%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage   82.47%   82.13%   -0.34%     
==========================================
  Files          33       33              
  Lines         622      627       +5     
  Branches      107      107              
==========================================
+ Hits          513      515       +2     
- Misses         70       73       +3     
  Partials       39       39

Impacted Files	Coverage Δ
src/extensions/functions/getVersion.ts	`64.28% <0%> (ø)`	⬆️
...extensions/functions/removeNonVersionCharacters.ts	`100% <100%> (ø)`	⬆️
src/extensions/functions/updateRequirement.ts	`84.78% <50%> (-3.59%)`	⬇️
src/extensions/functions/checkCLI.ts	`87.5% <66.66%> (-5.36%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0cede...3bca7ad. Read the comment docs.

TravisBuddy · 2018-03-02T05:38:02Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

Node.js: 8

npm run test:ci

> solidarity@1.1.1 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts (16.698s)
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/checkRequirementPlugins.ts
PASS __tests__/integration/solidarity-check/check-valid.ts (20.73s)
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/quirksNodeModules.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
FAIL __tests__/integration/solidarity-report/report-basic.ts
  ● solidarity report works

    expect(received).toBeTruthy()
    
    Expected value to be truthy, instead received
      false

      29 |       expect(result.stdout.includes('CPU')).toBeTruthy()
      30 |       expect(result.stdout.includes('Report Info')).toBeTruthy()
    > 31 |       expect(result.stdout.includes('yarn')).toBeTruthy()
      32 |       expect(result.stdout.includes('node')).toBeTruthy()
      33 |       expect(result.code).toBe(0)
      34 |       done()
      
      at then.result (__tests__/integration/solidarity-report/report-basic.ts:31:46)

PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/commands/create.ts
PASS __tests__/command_helpers/findPluginInfo.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/integration/solidarity-snapshot/snapshot-nada.ts (5.147s)
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/command_helpers/solidarityReport.ts
PASS __tests__/commands/report.ts
PASS __tests__/command_helpers/createPlugin.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/schema/validateExampleSchema.ts

Summary of all failing tests
FAIL __tests__/integration/solidarity-report/report-basic.ts
  ● solidarity report works

    expect(received).toBeTruthy()
    
    Expected value to be truthy, instead received
      false

      29 |       expect(result.stdout.includes('CPU')).toBeTruthy()
      30 |       expect(result.stdout.includes('Report Info')).toBeTruthy()
    > 31 |       expect(result.stdout.includes('yarn')).toBeTruthy()
      32 |       expect(result.stdout.includes('node')).toBeTruthy()
      33 |       expect(result.code).toBe(0)
      34 |       done()
      
      at then.result (__tests__/integration/solidarity-report/report-basic.ts:31:46)


Test Suites: 1 failed, 36 passed, 37 total
Tests:       1 failed, 159 passed, 160 total
Snapshots:   45 passed, 45 total
Time:        93.136s
Ran all test suites.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.1 test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.1 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-03-02T05_35_54_501Z-debug.log

yarn danger ci

yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
No issues or messages were sent. Removing any existing messages.
Done in 7.26s.

GantMan added 4 commits March 1, 2018 20:20

improved integraiton testing ✅

e156d97

verified basic commands

0db8d99

testing empty snapshot

7141494

handle errors better

6b76f6e

GantMan added 2 commits March 1, 2018 23:01

fix snapshots to not be machine specific

3dbf728

fixup tests for windows

310bfa5

fixing more stuff for windows

5b3ddb9

GantMan added 6 commits March 2, 2018 08:39

lower bar for tests

48939b6

handling windows problems right

caec851

add ugly output to tests for windows

e121b47

debugging cli

a57c1a9

try lowering number for windows CI

975de77

stay in temp dir for test

3bca7ad

GantMan merged commit 6ebc451 into master Mar 2, 2018

GantMan deleted the fixups_for_new_version branch March 2, 2018 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

✨ Fixups for new version #180

✨ Fixups for new version #180

Uh oh!

GantMan commented Mar 2, 2018

Uh oh!

TravisBuddy commented Mar 2, 2018

Uh oh!

codecov bot commented Mar 2, 2018 •

edited

Loading

Uh oh!

TravisBuddy commented Mar 2, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

✨ Fixups for new version #180

✨ Fixups for new version #180

Uh oh!

Conversation

GantMan commented Mar 2, 2018

Uh oh!

TravisBuddy commented Mar 2, 2018

Travis tests have failed

Node.js: node

Node.js: 8

Uh oh!

codecov bot commented Mar 2, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TravisBuddy commented Mar 2, 2018

Travis tests have failed

Node.js: node

Node.js: 8

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Mar 2, 2018 •

edited

Loading