这是indexloc提供的服务，不要输入任何密码
Skip to content

Plugin generator #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 25, 2018
Merged

Plugin generator #174

merged 15 commits into from
Feb 25, 2018

Conversation

@GantMan
Copy link
Member

@GantMan GantMan commented Feb 19, 2018 •
edited
Loading

empower anyone to be able to type solidarity create plugin and 🎉 they are prompted and given a process to generate a simple plugin for Solidarity.

Improvements?

  • link to docs after creating a plugin
  • thicken that readme
  • ask for a description to re-use
  • detect the user's github url from git
  • add tests

@codecov
Copy link

codecov bot commented Feb 19, 2018 •
edited
Loading

Codecov Report

Merging #174 into master will decrease coverage by 0.31%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   83.18%   82.87%   -0.32%     
==========================================
  Files          30       32       +2     
  Lines         577      613      +36     
  Branches       98      103       +5     
==========================================
+ Hits          480      508      +28     
- Misses         64       69       +5     
- Partials       33       36       +3
Impacted Files Coverage Δ
src/types.ts 100% <ø> (ø) ⬆️
src/commands/create.ts 100% <100%> (ø)
src/extensions/functions/createPlugin.ts 65.21% <65.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba463fd...1e6220e. Read the comment docs.

@TravisBuddy
Copy link
Contributor

TravisBuddy commented Feb 20, 2018

Travis tests have failed

Hey Gant Laborde,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci 
> solidarity@1.1.1 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/checkRequirementPlugins.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/findPluginInfo.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/command_helpers/solidarityReport.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 31 passed, 31 total
Tests:       144 passed, 144 total
Snapshots:   37 passed, 37 total
Time:        11.779s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/

ERROR: /home/travis/build/infinitered/solidarity/src/extensions/functions/createPlugin.ts[13, 9]: 'description' is declared but its value is never read.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.1 test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.1 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-02-20T03_28_55_684Z-debug.log

yarn danger ci 
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
No issues or messages were sent. Removing any existing messages.
Done in 2.92s.

Node.js: 8

npm run test:ci 
> solidarity@1.1.1 test:ci /home/travis/build/infinitered/solidarity
> jest --ci --runInBand && yarn test:extras

PASS __tests__/commands/snapshot.ts
PASS __tests__/command_helpers/checkRequirement.ts
PASS __tests__/command_helpers/updateRequirement.ts
PASS __tests__/command_helpers/reviewRule.ts
PASS __tests__/command_helpers/appendSolidaritySettings.ts
PASS __tests__/command_helpers/checkShell.ts
PASS __tests__/commands/solidarity.ts
PASS __tests__/command_helpers/checkRequirementPlugins.ts
PASS __tests__/command_helpers/getSolidaritySettings.ts
PASS __tests__/command_helpers/getVersion.ts
PASS __tests__/command_helpers/checkCLIForUpdates.ts
PASS __tests__/command_helpers/printResults.ts
PASS __tests__/command_helpers/removeNonVersionCharacters.ts
PASS __tests__/command_helpers/updateVersions.ts
PASS __tests__/command_helpers/findPluginInfo.ts
PASS __tests__/command_helpers/getLineWithVersion.ts
PASS __tests__/command_helpers/skipRule.ts
PASS __tests__/extensions/extensionCheck.ts
PASS __tests__/index.ts
PASS __tests__/commands/help.ts
PASS __tests__/command_helpers/checkCLI.ts
PASS __tests__/command_helpers/checkENV.ts
PASS __tests__/command_helpers/checkDir.ts
PASS __tests__/command_helpers/setSolidaritySettings.ts
PASS __tests__/command_helpers/checkFile.ts
PASS __tests__/command_helpers/solidarityReport.ts
PASS __tests__/integration/solidarity-check/check-invalid.ts
PASS __tests__/commands/report.ts
PASS __tests__/docs/testDocs.ts
PASS __tests__/command_helpers/binaryExists.ts
PASS __tests__/schema/validateExampleSchema.ts

Test Suites: 31 passed, 31 total
Tests:       144 passed, 144 total
Snapshots:   37 passed, 37 total
Time:        16.642s
Ran all test suites.
yarn run v1.3.2
$ tslint -p . && yarn madge --extensions ts --circular src/

ERROR: /home/travis/build/infinitered/solidarity/src/extensions/functions/createPlugin.ts[13, 9]: 'description' is declared but its value is never read.

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.1 test:ci: `jest --ci --runInBand && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.1 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-02-20T03_28_51_679Z-debug.log

yarn danger ci 
yarn run v1.3.2
$ /home/travis/build/infinitered/solidarity/node_modules/.bin/danger ci
You may have updated from Danger 2.x -> 3.x without updating from `danger` to `danger ci`.
Done in 2.86s.

@GantMan GantMan merged commit 848f71f into master Feb 25, 2018
@GantMan GantMan deleted the plugin-generator branch February 25, 2018 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GantMan @TravisBuddy