Fight node modules
#178
Closed
Fight node modules
#178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GantMan
commented
Feb 26, 2018
| test('errors with message when an improper semver is sent', async () => { | ||
| expect(await checkCLI(badSemver, context)).toBe(`Invalid semver rule ${badSemver.semver}`) | ||
| }) | ||
|
|
Member
Author
There was a problem hiding this comment.
I identified a missing test, and added it as lagniappe in this PR. Sorry for the distraction, but I'm always trying to up the % coverage.
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
==========================================
- Coverage 82.87% 82.84% -0.03%
==========================================
Files 32 33 +1
Lines 613 618 +5
Branches 103 104 +1
==========================================
+ Hits 508 512 +4
- Misses 69 70 +1
Partials 36 36
Continue to review full report at Codecov.
|
Member
Author
|
closing in favor of #179 this is the exact same code but for some reason there's a crash in windows, not sure why or what. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node will inject its own bin to the front of
$PATH, as identified in #175This simply moves that injection to the back to prefer global over anything
node_modules/.Tests included. I attempted to go a wrong way first, and that left strange artifacts I had to clean up. Squash to kill the noise
Closes: #175