-
Notifications
You must be signed in to change notification settings - Fork 48
⚒ Upgrades to the latest Gluegun beta #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 dangerJS |
Travis tests have failedHey Jamon Holmgren, Node.js: nodenpm run test:ciyarn danger ciNode.js: 8npm run test:ciyarn danger ci |
|
Yikes! The bots attacked. |
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 32 32
Lines 613 613
Branches 103 103
=======================================
Hits 508 508
Misses 69 69
Partials 36 36
Continue to review full report at Codecov.
|
|
That's better. |
GantMan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dude, thanks so much for doing this!
Looks great!
Upgrades to latest Gluegun beta.
Switches:
(And similar require statements elsewhere in the code base)
Tests now pass, although that took a bit of messing around.
I also had to redefine all the extension types, since
strictNullCheckswas failing due to optional properties. Since they're all included, I made them required. Per infinitered/gluegun#367.