add circular dependency check #153

GantMan · 2017-12-28T05:27:38Z

No description provided.

TravisBuddy · 2017-12-28T05:31:24Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci && tslint -p .

PASS __tests__/command_helpers/skipRule.ts (19.263s)
PASS __tests__/command_helpers/getLineWithVersion.ts (19.752s)
PASS __tests__/command_helpers/removeNonVersionCharacters.ts (19.745s)
PASS __tests__/command_helpers/setSolidaritySettings.ts (19.67s)
PASS __tests__/commands/help.ts (20.401s)
PASS __tests__/docs/testDocs.ts (19.674s)
PASS __tests__/command_helpers/checkENV.ts (20.652s)
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.0 test:ci: `jest --ci && tslint -p .`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.0 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-12-28T05_29_28_971Z-debug.log

codecov · 2017-12-28T05:31:38Z

Codecov Report

Merging #153 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #153   +/-   ##
=======================================
  Coverage   81.64%   81.64%           
=======================================
  Files          28       28           
  Lines         534      534           
  Branches       83       83           
=======================================
  Hits          436      436           
  Misses         66       66           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46cf798...1ce40f0. Read the comment docs.

TravisBuddy · 2017-12-28T05:34:41Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci && tslint -p .

PASS __tests__/command_helpers/setSolidaritySettings.ts (19.122s)
PASS __tests__/schema/validateExampleSchema.ts (19.428s)
PASS __tests__/command_helpers/checkENV.ts (20.129s)
PASS __tests__/command_helpers/getLineWithVersion.ts (19.956s)
PASS __tests__/commands/help.ts (20.237s)
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.0 test:ci: `jest --ci && tslint -p .`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.0 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-12-28T05_33_12_692Z-debug.log

TravisBuddy · 2017-12-28T05:42:05Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci && yarn test:extras

PASS __tests__/command_helpers/getLineWithVersion.ts (23.907s)
PASS __tests__/command_helpers/setSolidaritySettings.ts (24.511s)
PASS __tests__/command_helpers/checkENV.ts (25.693s)
PASS __tests__/command_helpers/removeNonVersionCharacters.ts (28.207s)
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.0 test:ci: `jest --ci && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.0 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-12-28T05_41_06_711Z-debug.log

TravisBuddy · 2017-12-28T05:50:20Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci && yarn test:extras

PASS __tests__/schema/validateExampleSchema.ts (19.073s)
PASS __tests__/docs/testDocs.ts (19.771s)
PASS __tests__/commands/help.ts (20.622s)
PASS __tests__/command_helpers/skipRule.ts (21.785s)
PASS __tests__/command_helpers/removeNonVersionCharacters.ts (20.981s)
PASS __tests__/command_helpers/checkENV.ts (21.779s)
PASS __tests__/command_helpers/setSolidaritySettings.ts (21.148s)
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.0 test:ci: `jest --ci && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.0 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-12-28T05_48_23_071Z-debug.log

TravisBuddy · 2017-12-28T05:57:33Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

TravisBuddy · 2017-12-28T15:52:20Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci && yarn test:extras

PASS __tests__/command_helpers/setSolidaritySettings.ts (33.157s)
PASS __tests__/command_helpers/checkENV.ts (33.828s)
PASS __tests__/command_helpers/removeNonVersionCharacters.ts (34.189s)
PASS __tests__/command_helpers/skipRule.ts (34.354s)
PASS __tests__/docs/testDocs.ts (33.707s)
PASS __tests__/command_helpers/getLineWithVersion.ts (34.909s)
PASS __tests__/commands/help.ts (35.276s)
PASS __tests__/schema/validateExampleSchema.ts (37.601s)
PASS __tests__/commands/solidarity.ts (47.047s)
PASS __tests__/extensions/extensionCheck.ts (47.228s)
PASS __tests__/index.ts (49.266s)
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.0 test:ci: `jest --ci && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.0 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-12-28T15_51_11_927Z-debug.log

TravisBuddy · 2017-12-28T16:10:26Z

Travis tests have failed

Hey Gant,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: node

npm run test:ci

> solidarity@1.1.0 test:ci /home/travis/build/infinitered/solidarity
> jest --ci && yarn test:extras

PASS __tests__/docs/testDocs.ts (14.278s)
PASS __tests__/commands/help.ts (22.009s)
PASS __tests__/command_helpers/setSolidaritySettings.ts (27.881s)
PASS __tests__/schema/validateExampleSchema.ts (25.26s)
PASS __tests__/command_helpers/removeNonVersionCharacters.ts (29.731s)
PASS __tests__/command_helpers/getLineWithVersion.ts (27.442s)
PASS __tests__/command_helpers/checkENV.ts (28.473s)
events.js:136
      throw er; // Unhandled 'error' event
      ^

Error [ERR_IPC_CHANNEL_CLOSED]: Channel closed
    at ChildProcess.target.send (internal/child_process.js:606:16)
    at Object.send (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/fork.js:24:17)
    at Farm.stopChild (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:131:11)
    at Farm.<anonymous> (/home/travis/build/infinitered/solidarity/node_modules/worker-farm/lib/farm.js:96:10)
    at ontimeout (timers.js:466:11)
    at tryOnTimeout (timers.js:304:5)
    at Timer.listOnTimeout (timers.js:264:5)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! solidarity@1.1.0 test:ci: `jest --ci && yarn test:extras`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the solidarity@1.1.0 test:ci script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2017-12-28T16_10_22_886Z-debug.log

GantMan · 2017-12-28T20:38:31Z

package.json

    "shipit": "tsc && np",
    "test": "jest && yarn test:extras",
-    "test:ci": "jest --ci && yarn test:extras",
+    "test:ci": "jest --ci --runInBand && yarn test:extras",


@mattathompson - this was the issue with testing on travis CI! I thought --ci would do it, but nope!

@GantMan: Why does not running the specs serially cause issues on Travis? Might be a dumb question but, I'll take that risk

Not a dumb question. So tests are designed to be forked processes for speed, but CI stops forked processes in order to protect from people getting insane processing power on those public machines or causing fork bombs and killing the server.

Result: When Jest forks a process, the server kills it ASAP, causing closed connections before a test finishes running, resulting in an error.

TLDR: The Jest process farm fights the Travis process killer and Jest loses 80% of the time causing non-deterministic testing.

Oh, wow. Thats insane. Thanks for the explanation.

add circular dependency check

b596a75

uses self in tests

dc935e5

move test items to extras

b68afa2

fixup for windows

c557222

more timout fixing

b6c7651

fix tests for good

1ce40f0

GantMan commented Dec 28, 2017

View reviewed changes

GantMan merged commit 6d6307b into master Dec 28, 2017

GantMan deleted the use_madge branch December 28, 2017 20:46

add circular dependency check #153

add circular dependency check #153

Uh oh!

Conversation

GantMan commented Dec 28, 2017

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

codecov bot commented Dec 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

TravisBuddy commented Dec 28, 2017

Travis tests have failed

Node.js: node

Uh oh!

GantMan Dec 28, 2017

Choose a reason for hiding this comment

Uh oh!

mattathompson Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

GantMan Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

GantMan Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

mattathompson Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Dec 28, 2017 •

edited

Loading