🔧 Teaches jest about source maps and thresholds #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GantMan
approved these changes
Dec 2, 2017
Member
GantMan
left a comment
There was a problem hiding this comment.
Thanks so much! I knew there were some strange sourcemap issues, I just figured they were upstream changes I would await... and wait... and wait.
Hah, turns out it was a setting I missed! Thanks so much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage + Source Maps
Jest needs to be told to use source maps with the
mapCoverage: trueinpackage.jsonor via--mapCoverageon the command line.I also turned on external source maps in
tsconfig.jsonas well.--no-cache --ci
For
yarn coverage, I turned off caching and other optimizations to go with a vanilla/from-scratch run. It's "safer" but slower.Coverage Thresholds
Now that source maps work with jest, your coverage score went up! 🎉
I locked each of the scores in to what they are now. You can adjust these to your own goals and comfort levels in
package.json>jest>coverageThreshold>global.