🙌 lint change and expose envinfo #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 83.13% 83.15% +0.02%
==========================================
Files 30 30
Lines 575 576 +1
Branches 97 97
==========================================
+ Hits 478 479 +1
Misses 64 64
Partials 33 33
Continue to review full report at Codecov.
|
Contributor
|
I would personally name it envinfoHelpers. At the risk of being verbose, I think it makes sense to have the package name in the context property. Also a heads up - with 4.x-beta I've been making some changes to the structure of the project, and I'm not sure I'm finished with it yet. Many methods will still be exposed via helpers, but I'm not sure how much to expose, or if I will be subdividing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
envinfo now exposed on solidarity. To be used on upcoming plugins!
( @tabrindle - I couldn't access it via require, so now I'm affixing it. )
Also, this fixes the Standard vs Prettier fight.
prettier/prettier#1139