feat(reactotron-react-native): enable trackGlobalLogs in useReactNative by default #1327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply Sweep Rules to your PR?
|
0a24040 to
f75dc2d
Compare
Contributor
Author
|
This will requite a new PR to ignite to update to the latest version to remove this snippet, and remove some references to |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new core plugin called
trackGlobalLogsto theuseReactNativedefault plugins, which will automatically trackconsole.log,console.warn, andconsole.debugwithout needing to do calls toReactotron.logorconsole.tron.log.This has been enabled in Ignite for several releases now, so we will be able to remove this snippet.
Monkey patching globals like console log is not ideal but we determined that we would expect a debugging tool to collect logs. We also already do similar strategies for inspecting network traffic, so we think this is a tradeoff worth making.