Feat/add devclient cli command #3002
Draft
+460
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
322117a to
508f85b
Compare
| ) | ||
| p() | ||
| command( | ||
| "devclient ", |
Contributor
Author
There was a problem hiding this comment.
note: I think they're technically called "Development builds". The "devclient" is actually this thing. Maybe we should rename this before merging to get the terminology correct.
|
|
||
| module.exports = { | ||
| description: "Download pre-built Expo development clients from GitHub releases", | ||
| run: async function (toolbox: GluegunToolbox) { |
Contributor
Author
There was a problem hiding this comment.
note: we should figure out what we want to track for usage, and where we want to track it. there are a few paths here (did they find a matching download, if so, which one, if not which one did they pick, and then which of the three types of downloads did they choose).
I think we probably want to start tracking before we merge so we don't miss any data, but I'm open to merging and figuring that out later if we're OK with dropping some insights early on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new CLI command,
devclient, to download pre-built development builds and launch from the command line.TODOs
Screenshots
Works when it finds a matching version
download-script-demo-matched-version.mov
Works when no matching version found
works-when-no-release-found.mov
Checklist
README.mdand other relevant documentation has been updated with my changes