fix: update worklets exclude to drop version #3001
Merged
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolsoftwaretyler
approved these changes
Oct 4, 2025
Contributor
coolsoftwaretyler
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this and sorry I missed it. I had already re-ignited locally and only tested the install, not the new command correctly.
Contributor
Author
|
@coolsoftwaretyler all good, I would have expected it to work the way you constructed it. It certainly used to work that way |
Contributor
Author
|
After some manual testing, I have to put back |
coolsoftwaretyler
approved these changes
Oct 5, 2025
Contributor
coolsoftwaretyler
left a comment
There was a problem hiding this comment.
LGTM, some day we'll evolve past legacy peer deps :(
infinitered-circleci
pushed a commit
that referenced
this pull request
Oct 6, 2025
## [11.2.1](v11.2.0...v11.2.1) (2025-10-06) ### Bug Fixes * **boilerplate:** update worklets exclude to drop version ([#3001](#3001) by [@frankcalise](https://github.com/frankcalise)) ([3e8c37e](3e8c37e))
Collaborator
|
🎉 This PR is included in version 11.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ChristopherGabba
added a commit
to ChristopherGabba/ignite
that referenced
this pull request
Oct 6, 2025
## [11.2.1](infinitered/ignite@v11.2.0...v11.2.1) (2025-10-06) ### Bug Fixes * **boilerplate:** update worklets exclude to drop version ([infinitered#3001](infinitered#3001) by [@frankcalise](https://github.com/frankcalise)) ([3e8c37e](infinitered@3e8c37e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's an issue when providing the version in the
expo.install.excludeskeys, which might be related to the -nightly suffix as it doesn't fall into some of the prerelease tags (not 100% on this).Looking at the docs, it seems like they may have migrated away from providing the specific version in the key anyway? This doesn't match with Expo's test cases on the matter, but it is what the docs say now.
In addition to this, I updated the
expo-routerversion we slide into the template from the new command. This wasn't required, asexpo install --fixactually would have fixed it anyway, should the worklets install would have actually been excluded.Screenshots
Before terminal output
Note how it says it is skipping them, but it still lists it as a version it is going to update with
install --checkAfter terminal output
Then, when dropping the version from package.json: