这是indexloc提供的服务,不要输入任何密码
Skip to content

Conversation

@coolsoftwaretyler
Copy link
Contributor

@coolsoftwaretyler coolsoftwaretyler commented Sep 6, 2025

Description

This PR enables Git LFS so we can add development builds to the repository and make it easy for users to get spun up in a way that feels kind of like Expo Go (people can just download the latest development build, install on emulator/simulator, write TypeScript, and see the results). Just a nice convenience.

Adds some development builds created from latest https://github.com/infinitered/ignite-development-builds.

Updates .github/CONTRIBUTING.md to mention the git LFS support.

Copy link
Member

@robinheinze robinheinze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions:

Do you know what kind of impact this will have on folks cloning Ignite to contribute? Will cloning take longer?

Can we add something to the README / docs about how users can install and run these builds?

@coolsoftwaretyler
Copy link
Contributor Author

@robinheinze:

  1. It depends. For users that don't have git LFS installed, I think these files will just be gracefully ignored. But if they have LFS installed, it'll pull these items. Looks like there's a way to skip that, though. I can update the docs to include this information before merge.
  2. Yes, I'll also make sure to do that. I was focused on getting these to build and ship, but this PR is a good opportunity to at least make a first pass at the documentation.

@coolsoftwaretyler
Copy link
Contributor Author

Based on discussion in Slack, I think we're going to try and just upload these artifacts as releases directly, and keep them out of source control. Will either close this PR or convert it to docs only sometime soon.

@coolsoftwaretyler
Copy link
Contributor Author

We ended up doing this with the GitHub CLI, closing PR for now and will submit a separate PR with docs and a download script for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants