fix(cli): handle boolean negotiation for --no-timeout CLI argument #2998
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankcalise
approved these changes
Sep 22, 2025
Contributor
frankcalise
left a comment
There was a problem hiding this comment.
Looks good, thanks Sean!
infinitered-circleci
pushed a commit
that referenced
this pull request
Sep 23, 2025
## [11.1.3](v11.1.2...v11.1.3) (2025-09-23) ### Bug Fixes * **cli:** handle boolean negotiation for --no-timeout CLI argument ([#2998](#2998)) ([df2ae6f](df2ae6f))
Collaborator
|
🎉 This PR is included in version 11.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Yargs parses
--no-timeoutas{ timeout: false }(boolean negation), but the code only checkedoptions.noTimeout, which wasundefined.Solution
Updated timeout logic to handle both:
options.noTimeout(from--no-timeout=true/false)options.timeout(from--no-timeoutor--timeout)Testing
All flag variations now work correctly:
No flag → timeout enabled (default)
--no-timeout→ timeout disabled--no-timeout=true→ timeout disabled--no-timeout=false→ timeout enabled--timeout=false→ timeout disabledIssues: fixes App creation time out with the latest ignite cli #2996
Checklist