fix(cli): run project path validation checks #2985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces a function to warn users about long project paths on Windows, which can lead to failures in Android CMake/Ninja builds due to MAX_PATH limitations.
frankcalise
reviewed
Aug 14, 2025
Contributor
There was a problem hiding this comment.
I like it! Couple of thoughts/suggestions I can think of now that we went down this rabbit hole:
- Move
checkWindowsPathLengthintosrc/tools/validation.tssince it seems to fit there - Consider renaming
checkWindowsPathLengthtovalidateProjectPathand we could have platform specific checks in there?- For example, Windows needs the length check
- Honestly, macOS needs a check for spaces in the path because Xcode will die on build if spaces are in the directory I'm pretty sure
frankcalise
approved these changes
Aug 16, 2025
Contributor
frankcalise
left a comment
There was a problem hiding this comment.
Thanks for the refactor! Tested it on my Windows machine and was able to get the warning prompt when appropriate.
Co-authored-by: Frank Calise <fcalise@gmail.com>
infinitered-circleci
pushed a commit
that referenced
this pull request
Aug 18, 2025
## [11.1.1](v11.1.0...v11.1.1) (2025-08-18) ### Bug Fixes * **cli:** run project path validation checks ([#2985](#2985)) ([c54aeec](c54aeec))
Collaborator
|
🎉 This PR is included in version 11.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This update introduces a function to warn users about long project paths on Windows, which can lead to failures in Android CMake/Ninja builds due to MAX_PATH limitations.
Checklist